Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI/UX] Fix English grammar for launch argument box placeholder #4112

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

marcusziade
Copy link

@marcusziade marcusziade commented Nov 14, 2024

This is a slight improvement to the UI, as it's not grammatically correct currently and sticks out.


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)

Before

image

After

image

This is a slight improvement to the UI, as it's not grammatically
correct currently and sticks out.
@flavioislima
Copy link
Member

flavioislima commented Nov 14, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@marcusziade
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

Copy link
Collaborator

@arielj arielj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to add the default value of this translation in https://github.com/Heroic-Games-Launcher/HeroicGamesLauncher/blob/main/src/frontend/screens/Settings/components/LauncherArgs.tsx#L61, it helps to find the context if needed

   placeholder={t('options.gameargs.placeholder', 'Put the launcher arguments here')}

@marcusziade
Copy link
Author

marcusziade commented Dec 21, 2024

Getting formatting issues when pushing the code, when I change line 61 to that, not sure why

Checking formatting...
[warn] src/frontend/screens/Settings/components/LauncherArgs.tsx
[warn] Code style issues found in the above file. Run Prettier to fix.
 ELIFECYCLE  Command failed with exit code 1.
error: failed to push some refs to 'https://github.com/marcusziade/HeroicGamesLauncher.git'

@arielj
Copy link
Collaborator

arielj commented Dec 21, 2024

Getting formatting issues when pushing the code, when I change line 61 to that, not sure why

Checking formatting...
[warn] src/frontend/screens/Settings/components/LauncherArgs.tsx
[warn] Code style issues found in the above file. Run Prettier to fix.
 ELIFECYCLE  Command failed with exit code 1.
error: failed to push some refs to 'https://github.com/marcusziade/HeroicGamesLauncher.git'

you have to format it like this:

      placeholder={t(
        'options.gameargs.placeholder',
        'Put the launcher arguments here'
      )}

I suggest configuring a formatter in your code editor to automatically apply the prettier rules on save

or run pnpm prettier-fix

@marcusziade
Copy link
Author

Got it, should've realized you have a prettier config in the repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants