-
-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UI/UX] Fix English grammar for launch argument box placeholder #4112
base: main
Are you sure you want to change the base?
[UI/UX] Fix English grammar for launch argument box placeholder #4112
Conversation
This is a slight improvement to the UI, as it's not grammatically correct currently and sticks out.
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to add the default value of this translation in https://github.com/Heroic-Games-Launcher/HeroicGamesLauncher/blob/main/src/frontend/screens/Settings/components/LauncherArgs.tsx#L61, it helps to find the context if needed
placeholder={t('options.gameargs.placeholder', 'Put the launcher arguments here')}
Getting formatting issues when pushing the code, when I change line 61 to that, not sure why
|
you have to format it like this: placeholder={t(
'options.gameargs.placeholder',
'Put the launcher arguments here'
)} I suggest configuring a formatter in your code editor to automatically apply the prettier rules on save or run |
Got it, should've realized you have a prettier config in the repo. |
This is a slight improvement to the UI, as it's not grammatically correct currently and sticks out.
Use the following Checklist if you have changed something on the Backend or Frontend:
Before
After