-
-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add anticheat information to the log file if there is anticheat infor… #4128
base: main
Are you sure you want to change the base?
add anticheat information to the log file if there is anticheat infor… #4128
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
…mation to be found remove elint error in shortcuts.ts
7240bb4
to
b8db351
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected
I left a minor comment
@@ -175,7 +175,7 @@ async function generateMacOsApp(gameInfo: GameInfo) { | |||
logInfo('Generating macOS shortcut', LogPrefix.Backend) | |||
|
|||
// shortcutFiles => [desktop, menu] on mac, we don't add desktop shortcut | |||
const appShortcut = shortcutFiles(gameInfo.title)[1]! | |||
const appShortcut = shortcutFiles(gameInfo.title)[1] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this change seems unrelated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it kind of is, but it wouldn't let me push without fixing it. it was an elinter error or something.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh I see, it was already removed in the main branch, looks like the main branch in your repo might be out of sync
you can probably rebase this branch on over the latest main and this should disappear
<--- Put the description here --->
Addresses #3584
Use the following Checklist if you have changed something on the Backend or Frontend: