Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add anticheat information to the log file if there is anticheat infor… #4128

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

RawToast225
Copy link
Contributor

<--- Put the description here --->
Addresses #3584

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@flavioislima
Copy link
Member

flavioislima commented Nov 19, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@RawToast225
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

…mation to be found

remove elint error in shortcuts.ts
Copy link
Collaborator

@arielj arielj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected

I left a minor comment

@@ -175,7 +175,7 @@ async function generateMacOsApp(gameInfo: GameInfo) {
logInfo('Generating macOS shortcut', LogPrefix.Backend)

// shortcutFiles => [desktop, menu] on mac, we don't add desktop shortcut
const appShortcut = shortcutFiles(gameInfo.title)[1]!
const appShortcut = shortcutFiles(gameInfo.title)[1]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change seems unrelated

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it kind of is, but it wouldn't let me push without fixing it. it was an elinter error or something.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh I see, it was already removed in the main branch, looks like the main branch in your repo might be out of sync

you can probably rebase this branch on over the latest main and this should disappear

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants