wip #476
rust.yml
on: push
build-test-win
0s
build-test-mac
6m 19s
build
9m 47s
test-and-valgrind
0s
Annotations
11 errors and 1 warning
unsafe function's docs miss `# Safety` section:
src/reflection/mod.rs#L727
error: unsafe function's docs miss `# Safety` section
--> src/reflection/mod.rs:727:1
|
727 | / pub unsafe fn get_proxy_instance_id(
728 | | ctx: *mut libquickjs_sys::JSContext,
729 | | obj: &QuickJsValueAdapter,
730 | | ) -> Option<usize> {
| |__________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc
= note: `-D clippy::missing-safety-doc` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::missing_safety_doc)]`
|
use of `or_insert_with` to construct default value:
src/reflection/eventtarget.rs#L66
error: use of `or_insert_with` to construct default value
--> src/reflection/eventtarget.rs:66:14
|
66 | .or_insert_with(HashMap::new);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
|
redundant redefinition of a binding:
src/quickjs_utils/arrays.rs#L147
error: redundant redefinition of a binding
--> src/quickjs_utils/arrays.rs:147:5
|
147 | entry_value_ref: &QuickJsValueAdapter,
| ^^^^^^^^^^^^^^^
148 | ) -> Result<(), JsError> {
149 | let entry_value_ref = entry_value_ref;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: remove the redefinition of `entry_value_ref`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_locals
= note: `#[deny(clippy::redundant_locals)]` on by default
|
use of `unwrap_or` to construct default value:
src/features/console.rs#L241
error: use of `unwrap_or` to construct default value
--> src/features/console.rs:241:43
|
241 | _ => call_to_string(ctx, arg).unwrap_or(String::new()),
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
|
use of `unwrap_or` to construct default value:
src/features/console.rs#L196
error: use of `unwrap_or` to construct default value
--> src/features/console.rs:196:55
|
196 | _ => functions::call_to_string(ctx, &args[0]).unwrap_or(String::new()),
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
|
calling `push_str()` using a single-character string literal:
src/features/console.rs#L179
error: calling `push_str()` using a single-character string literal
--> src/features/console.rs:179:9
|
179 | output.push_str("[");
| ^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `output.push('[')`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str
= note: `-D clippy::single-char-add-str` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::single_char_add_str)]`
|
use of `unwrap_or` to construct default value:
src/features/console.rs#L160
error: use of `unwrap_or` to construct default value
--> src/features/console.rs:160:32
|
160 | call_to_string(ctx, value).unwrap_or(String::new())
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
|
use of `unwrap_or` to construct default value:
src/features/console.rs#L155
error: use of `unwrap_or` to construct default value
--> src/features/console.rs:155:67
|
155 | Ok(json_str) => primitives::to_string(ctx, &json_str).unwrap_or(String::new()),
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
|
use of `unwrap_or` to construct default value:
src/features/console.rs#L120
error: use of `unwrap_or` to construct default value
--> src/features/console.rs:120:60
|
120 | let mut f_val: String = call_to_string(ctx, value).unwrap_or(String::new());
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
|
use of `unwrap_or` to construct default value:
src/features/console.rs#L92
error: use of `unwrap_or` to construct default value
--> src/features/console.rs:92:60
|
92 | let mut i_val: String = call_to_string(ctx, value).unwrap_or(String::new());
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
= note: `-D clippy::unwrap-or-default` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::unwrap_or_default)]`
|
build
Clippy had exited with the 101 exit code
|
build
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/cache@v2, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|