don't panic on utf8 error

HiRoFa · Oct 15, 2024 · b0aa0ce · b0aa0ce
1 parent b334c37
commit b0aa0ce
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,7 @@
+# 0.14.4
+
+* don't panic on utf8 error in to_str
+
 # 0.14.3
 
 * update quickjs-ng to 0.6.0

diff --git a/Cargo.toml b/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "quickjs_runtime"
-version = "0.14.3"
+version = "0.14.4"
 authors = ["Andries Hiemstra <[email protected]>"]
 edition = "2021"
 description = "Wrapper API and utils for the QuickJS JavaScript engine with support for Promise, Modules, Async/await"

diff --git a/src/quickjs_utils/primitives.rs b/src/quickjs_utils/primitives.rs
@@ -124,7 +124,8 @@ pub unsafe fn to_str(
     }
 
     let cstr = std::ffi::CStr::from_ptr(ptr);
-    Ok(cstr.to_str().expect("bad cstr bad!"))
+    cstr.to_str()
+        .map_err(|e| JsError::new_string(format!("utf8 error: {e}")))
 
     //let s = cstr.to_string_lossy();