Merge pull request #112 from HicServices/hotfix/exceptions

Throw exceptions on invalid conversions

CHANGELOG.md

@@ -6,6 +6,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [1.2.6] - 2024-07-16
+
+- Throw exceptions on invalid conversion attempts
+
 ## [1.2.5] - 2024-07-11
 
 - Internal performance improvements, using ReadOnlySpan<char> instead of string internally
@@ -84,7 +88,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 - Initial port of content from [FAnsiSql](https://github.com/HicServices/FAnsiSql)
 
-[Unreleased]: https://github.com/HicServices/TypeGuesser/compare/v1.2.5...main
+[Unreleased]: https://github.com/HicServices/TypeGuesser/compare/v1.2.6...main
+[1.2.6]: https://github.com/HicServices/TypeGuesser/compare/v1.2.5...v1.2.6
 [1.2.5]: https://github.com/HicServices/TypeGuesser/compare/v1.2.4...v1.2.5
 [1.2.4]: https://github.com/HicServices/TypeGuesser/compare/v1.2.3...v1.2.4
 [1.2.3]: https://github.com/HicServices/TypeGuesser/compare/v1.2.2...v1.2.3

SharedAssemblyInfo.cs

@@ -9,6 +9,6 @@
 [assembly: AssemblyTrademark("")]
 [assembly: AssemblyCulture("")]
 
-[assembly: AssemblyVersion("1.2.5")]
-[assembly: AssemblyFileVersion("1.2.5")]
-[assembly: AssemblyInformationalVersion("1.2.5")]
+[assembly: AssemblyVersion("1.2.6")]
+[assembly: AssemblyFileVersion("1.2.6")]
+[assembly: AssemblyInformationalVersion("1.2.6")]

TypeGuesser/Deciders/BoolTypeDecider.cs

@@ -25,7 +25,7 @@ protected override IDecideTypesForStrings CloneImpl(CultureInfo newCulture)
 
         candidateString = StripWhitespace(candidateString);
 
-        return candidateString.Length switch
+        bool? b = candidateString.Length switch
         {
             1 => "1tTyYjJ0fFnN".IndexOf(candidateString[0]) != -1 ? "0fFnN".IndexOf(candidateString[0]) == -1 : null,
             2 => candidateString.Equals("ja",StringComparison.OrdinalIgnoreCase) ? true :
@@ -41,6 +41,7 @@ protected override IDecideTypesForStrings CloneImpl(CultureInfo newCulture)
             5 => candidateString.Equals("false",StringComparison.OrdinalIgnoreCase) ? false : null,
             _ => null
         };
+        return b ?? throw new Exception("Invalid bool");
     }
 
     private static ReadOnlySpan<char> StripWhitespace(ReadOnlySpan<char> candidateString)

TypeGuesser/Deciders/DecimalTypeDecider.cs

@@ -31,7 +31,7 @@ protected override IDecideTypesForStrings CloneImpl(CultureInfo culture)
     }
 
     /// <inheritdoc />
-    protected override object? ParseImpl(ReadOnlySpan<char> value) => decimal.TryParse(value, NumberStyles.Any, Culture.NumberFormat, out var d) ? d : null;
+    protected override object ParseImpl(ReadOnlySpan<char> value) => decimal.Parse(value, NumberStyles.Any, Culture.NumberFormat);
 
     /// <inheritdoc/>
     protected override bool IsAcceptableAsTypeImpl(ReadOnlySpan<char> candidateString, IDataTypeSize? sizeRecord)

TypeGuesser/Deciders/IntTypeDecider.cs

@@ -19,7 +19,7 @@ protected override IDecideTypesForStrings CloneImpl(CultureInfo newCulture)
     }
 
     /// <inheritdoc />
-    protected override object? ParseImpl(ReadOnlySpan<char> value) => int.TryParse(value, NumberStyles.Any, Culture.NumberFormat, out var i) ? i : null;
+    protected override object ParseImpl(ReadOnlySpan<char> value) => int.Parse(value, NumberStyles.Any, Culture.NumberFormat);
 
     /// <inheritdoc/>
     protected override bool IsAcceptableAsTypeImpl(ReadOnlySpan<char> candidateString, IDataTypeSize? sizeRecord)

TypeGuesser/Guesser.cs

@@ -132,10 +132,10 @@ public void AdjustToCompensateForValue(object? o)
                     SR.Guesser_AdjustToCompensateForValue_GuesserPassedMixedTypeValues,o,o.GetType(),
                     Guess.CSharpType));
 
-            var oToString = o.ToString();
+            var oToString = o.ToString() ?? string.Empty;
 
             //we might need to fallback on a string later on, in this case we should always record the maximum length of input seen before even if it is acceptable as int, double, dates etc
-            Guess.Width = Math.Max(Guess.Width ?? -1,GetStringLength(oToString??string.Empty));
+            Guess.Width = Math.Max(Guess.Width ?? -1, GetStringLength(oToString.AsSpan()));
 
             //if it's a string
             if (o is string oAsString)