Updated Effective Area IDL Calculation Text File #305
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
November 22, 2024 17:13
|
Should the tests pass for these files changes (assuming the failures are due to that)? |
|
Hi @nabobalis Updating these tests and revising the code method for the interruption tolerance value should help us pass before moving forward with the merge |
nabobalis
reviewed
Dec 12, 2024
nabobalis
reviewed
Dec 12, 2024
| @@ -128,5 +130,5 @@ def test_effective_area_compare_idl(filename): | |||
| assert u.allclose( | |||
| actual_effective_area, | |||
| IDL_effective_area, | |||
| rtol=1e-6, | |||
| rtol=1e-4, #Moderate Precision | |||
There was a problem hiding this comment.
Currently testing different values
|
This fixes #292 right? |
|
Yes, I'll make sure to reference the issue to the PR and close the issue once I merge this PR |
added 7 commits
December 12, 2024 18:58
…1 passed, 1 warning, still working on script
|
My pull request (#310) supercedes this one. |
joyvelasquez
deleted the
Updated_Effective_Area_IDL_calculation_text_files
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the original IDL Effective Area text files used for testing XRTpy testing to align with the latest modified IDL linear interpolation method. These updates ensure the test files reflect the new Effective Area calculations, improving accuracy and consistency.