expand_2r #14
Open
expand_2r #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Exand 2r for GSVD, might not need to be merged, just for review and discuss some new variants. |
timholy
reviewed
Apr 25, 2025
| @@ -117,7 +117,7 @@ function gsvdrecover(X::AbstractArray, W0::AbstractArray, H0::AbstractArray, kad | |||
| U0, S0, V0 = f | |||
| U0, S0, V0 = U0[:,1:n], S0[1:n], V0[:,1:n] | |||
| Hadd, Λ = init_H(U0, S0, V0, W0, H0, kadd) | |||
| Wadd, a = init_W(X, W0, H0, Hadd) | |||
| Wadd, a = init_W(X, W0, H0, Hadd) | |||
There was a problem hiding this comment.
trailing whitespace. You can set vscode to delete it automatically: https://www.codexcafe.com/blog/remove-trailing-whitespace/
| # @show cs | ||
| W0_2, H0_2 = repeat(cs', m, 1).*W0_1, H0_1 | ||
| # W0_2, H0_2 = W0_1, H0_1 | ||
| return abs.(W0_2), abs.(H0_2), Λ |
There was a problem hiding this comment.
Why is the abs needed? If it has tiny negative values, would max.(0, W0_2) be more appropriate? abs nominally runs the risk of turning a large negative number positive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.