Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove OpenStruct from Uses cmd #18806

Merged
merged 2 commits into from
Nov 25, 2024
Merged

Remove OpenStruct from Uses cmd #18806

merged 2 commits into from
Nov 25, 2024

Conversation

dduugg
Copy link
Member

@dduugg dduugg commented Nov 23, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Relates to #18777

Replaces the use of OpenStruct in the uses command with a T::Struct. AFAICT, the OpenStruct defined all the necessary methods, so it isn't necessary to introduce add'l functionality.

(Some other minor cleanup is included.)

Library/Homebrew/formula.rb Show resolved Hide resolved
Library/Homebrew/test/cmd/uses_spec.rb Outdated Show resolved Hide resolved
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dduugg!

@MikeMcQuaid MikeMcQuaid merged commit 56780f3 into master Nov 25, 2024
28 checks passed
@MikeMcQuaid MikeMcQuaid deleted the rm-uses-ostruct branch November 25, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants