Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove OpenStruct from CLI::Args #18847

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Remove OpenStruct from CLI::Args #18847

wants to merge 2 commits into from

Conversation

dduugg
Copy link
Member

@dduugg dduugg commented Dec 1, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Resolves #18777

Notes incoming, draft for now to check downstream effects

@dduugg dduugg marked this pull request as draft December 1, 2024 00:55
@dduugg
Copy link
Member Author

dduugg commented Dec 3, 2024

Promising start, passes tests locally, but has an issue where methods are being defined twice – once when the cmd_args are read, and once when the args are set. I should be able to refine this approach by refining the approach to define and set attributes instead, then we'll see what the next blocker is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove OpenStruct dependency
1 participant