Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wezterm: remove preflight block #193124

Merged
merged 1 commit into from
Nov 24, 2024
Merged

wezterm: remove preflight block #193124

merged 1 commit into from
Nov 24, 2024

Conversation

khipp
Copy link
Member

@khipp khipp commented Nov 24, 2024

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

This PR removes the need for the preflight block, as it is not run before the audit and therefore causes it to fail.

@khipp khipp force-pushed the update-wezterm branch 2 times, most recently from a722be6 to 09423a2 Compare November 24, 2024 21:55
@khipp khipp changed the title wezterm*: remove preflight block wezterm: remove preflight block Nov 24, 2024
@chenrui333 chenrui333 merged commit cb83de4 into master Nov 24, 2024
11 checks passed
@chenrui333 chenrui333 deleted the update-wezterm branch November 24, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants