-
-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Protobuf 21.2 #105712
Closed
Closed
Protobuf 21.2 #105712
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
0aadbf4
protobuf 21.2
ezzieyguywuf 385c4d7
protobuf@3 3.20.1 (new formula)
carlocab 9182b5a
apache-arrow: revision bump (protobuf 21.2)
carlocab b4d2eab
bear: revision bump (protobuf 21.2)
carlocab 6624487
bloaty: revision bump (protobuf 21.2)
carlocab 5302aef
caffe: revision bump (protobuf 21.2)
carlocab a4ef62a
etcd-cpp-apiv3: revision bump (protobuf 21.2)
carlocab b0f4c9d
fastnetmon: revision bump (protobuf 21.2)
carlocab 78899f0
grpc: revision bump (protobuf 21.2)
carlocab 78f73b8
libphonenumber: revision bump (protobuf 21.2)
carlocab 63075df
libpulsar: revision bump (protobuf 21.2)
carlocab b60435e
libtorch: revision bump (protobuf 21.2)
carlocab 2662cb0
mavsdk: revision bump (protobuf 21.2)
carlocab 4dcf649
monero: revision bump (protobuf 21.2)
carlocab 10dd7c4
mosh: revision bump (protobuf 21.2)
carlocab 8d8a4a5
mysql: revision bump (protobuf 21.2)
carlocab 812be72
ncnn: revision bump (protobuf 21.2)
carlocab c5f12e3
netdata: revision bump (protobuf 21.2)
carlocab 952b722
ola: revision bump (protobuf 21.2)
carlocab fb15256
opencv: revision bump (protobuf 21.2)
carlocab 773cc7d
or-tools: revision bump (protobuf 21.2)
carlocab db950dd
osm-pbf: revision bump (protobuf 21.2)
carlocab 39068cd
percona-server: revision bump (protobuf 21.2)
carlocab 724784a
percona-xtrabackup: revision bump (protobuf 21.2)
carlocab 2e0d06a
protobuf-c: revision bump (protobuf 21.2)
carlocab d2b52c2
protoc-gen-grpc-web: revision bump (protobuf 21.2)
carlocab 9fba7aa
rethinkdb: revision bump (protobuf 21.2)
carlocab 02849f3
sysdig: revision bump (protobuf 21.2)
carlocab bfe2594
torchvision: revision bump (protobuf 21.2)
carlocab File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
../Formula/[email protected] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,62 @@ | ||
class ProtobufAT3 < Formula | ||
desc "Protocol buffers (Google's data interchange format)" | ||
homepage "https://github.com/protocolbuffers/protobuf/" | ||
url "https://github.com/protocolbuffers/protobuf/releases/download/v3.20.1/protobuf-all-3.20.1.tar.gz" | ||
sha256 "3a400163728db996e8e8d21c7dfb3c239df54d0813270f086c4030addeae2fad" | ||
license "BSD-3-Clause" | ||
|
||
keg_only :versioned_formula | ||
|
||
depends_on "[email protected]" => [:build, :test] | ||
# The Python3.9 bindings can be removed when Python3.9 is made keg-only. | ||
depends_on "[email protected]" => [:build, :test] | ||
|
||
uses_from_macos "zlib" | ||
|
||
def install | ||
# Don't build in debug mode. See: | ||
# https://github.com/Homebrew/homebrew/issues/9279 | ||
# https://github.com/protocolbuffers/protobuf/blob/5c24564811c08772d090305be36fae82d8f12bbe/configure.ac#L61 | ||
ENV.prepend "CXXFLAGS", "-DNDEBUG" | ||
ENV.cxx11 | ||
|
||
system "./autogen.sh" if build.head? | ||
system "./configure", "--disable-debug", "--disable-dependency-tracking", | ||
"--prefix=#{prefix}", "--with-zlib" | ||
system "make" | ||
system "make", "install" | ||
|
||
# Install editor support and examples | ||
pkgshare.install "editors/proto.vim", "examples" | ||
elisp.install "editors/protobuf-mode.el" | ||
|
||
ENV.append_to_cflags "-I#{include}" | ||
ENV.append_to_cflags "-L#{lib}" | ||
|
||
cd "python" do | ||
["3.9", "3.10"].each do |xy| | ||
site_packages = prefix/Language::Python.site_packages("python#{xy}") | ||
system "python#{xy}", *Language::Python.setup_install_args(prefix), | ||
"--install-lib=#{site_packages}", | ||
"--cpp_implementation" | ||
end | ||
end | ||
end | ||
|
||
test do | ||
testdata = <<~EOS | ||
syntax = "proto3"; | ||
package test; | ||
message TestCase { | ||
string name = 4; | ||
} | ||
message Test { | ||
repeated TestCase case = 1; | ||
} | ||
EOS | ||
(testpath/"test.proto").write testdata | ||
system bin/"protoc", "test.proto", "--cpp_out=." | ||
system Formula["[email protected]"].opt_bin/"python3", "-c", "import google.protobuf" | ||
system Formula["[email protected]"].opt_bin/"python3", "-c", "import google.protobuf" | ||
end | ||
end |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a little weird that we need this, since I always thought that
CMAKE_BUILD_TYPE=Release
already added-DNDEBUG
toC[XX]FLAGS
.It turns out that this is only true for
CMAKE_C_FLAGS
:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, no, it's definitely there: