Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: switch to SSH signing everywhere #206675

Merged
merged 1 commit into from
Feb 6, 2025
Merged

ci: switch to SSH signing everywhere #206675

merged 1 commit into from
Feb 6, 2025

Conversation

woodruffw
Copy link
Member

@woodruffw woodruffw commented Feb 5, 2025

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

This switches us to the new SSH signing key in all of homebrew-core's workflows, similar to what we did for brew with Homebrew/brew#19230.

@woodruffw woodruffw self-assigned this Feb 5, 2025
@woodruffw woodruffw requested review from MikeMcQuaid and a team as code owners February 5, 2025 22:55
@github-actions github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request workflows PR modifies GitHub Actions workflow files labels Feb 5, 2025
Copy link
Member

@p-linnane p-linnane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for knocking this out so quickly!

@p-linnane p-linnane added this pull request to the merge queue Feb 6, 2025
Merged via the queue into master with commit f15ef1d Feb 6, 2025
21 checks passed
@p-linnane p-linnane deleted the ww/ssh-signing branch February 6, 2025 07:54
@MikeMcQuaid
Copy link
Member

Great work, thanks @woodruffw!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge-skip `brew pr-automerge` will skip this pull request workflows PR modifies GitHub Actions workflow files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants