bash: depend on brewed ncurses

[fxcoudert]

Fixes #158667
Fixes #206736

We already decided to do this, but the PR failed because of CI misuse of brew bash: #162819

[fxcoudert]

First try failed with:

A job completed hook has been configured by the self-hosted runner administrator
Run '/Users/brew/job_completed.sh'
  shell: /opt/homebrew/bin/bash --noprofile --norc -e -o pipefail {0}
dyld[21128]: Library not loaded: /opt/homebrew/opt/ncurses/lib/libncursesw.6.dylib
  Referenced from: <D3DFE079-9820-3A3C-8A2C-C036AFFAE3A4> /opt/homebrew/Cellar/bash/5.2.37/bin/bash
  Reason: tried: '/opt/homebrew/opt/ncurses/lib/libncursesw.6.dylib' (no such file), '/System/Volumes/Preboot/Cryptexes/OS/opt/homebrew/opt/ncurses/lib/libncursesw.6.dylib' (no such file), '/opt/homebrew/opt/ncurses/lib/libncursesw.6.dylib' (no such file)

Trying harder to enforce use of system bash

[fxcoudert]

Hum, still not enough. Maybe @Bo98 has an idea.

[Bo98]

Certain parts of GitHub Actions uses the first bash on the path and we determined last time that it was impossible to avoid that behaviour.

We avoided the issue before by having no dependencies. What we could do instead is add special casing to remove brewed bash in job cleanup.

[cho-m]

What we could do instead is add special casing to remove brewed bash in job cleanup.

Sounds reasonable.

A possible alternative is modifying GITHUB_PATH during post.sh (perhaps echo /bin >>"$GITHUB_PATH"? didn't find way to remove paths)

[ZhongRuoyu]

CI is now unblocked and this is good to .

I believe the workflow changes here are no longer necessary so I suggest dropping those to maintain consistency.

[github-actions]

🤖 An automated task has requested bottles to be published to this PR.