Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CustomFontEmbedder.ts #1711

Closed
wants to merge 2 commits into from
Closed

Conversation

matt2023y
Copy link

@matt2023y matt2023y commented Dec 4, 2024

add postscriptName param to CustomFontEmbedder.for

What?

add a param postscriptName to CustomFontEmbedder.for

Why?

useful when using ttc file.

How?

add a param postscriptName to fontkit.create in CustomFontEmbedder.for

Testing?

I tested locally.

New Dependencies?

No

Screenshots

N/A

Suggested Reading?

No

Anything Else?

Checklist

  • I read CONTRIBUTING.md.
  • I read MAINTAINERSHIP.md#pull-requests.
  • I added/updated unit tests for my changes.
  • I added/updated integration tests for my changes.
  • I ran the integration tests.
  • I tested my changes in Node, Deno, and the browser.
  • I viewed documents produced with my changes in Adobe Acrobat, Foxit Reader, Firefox, and Chrome.
  • I added/updated doc comments for any new/modified public APIs.
  • My changes work for both new and existing PDF files.
  • I ran the linter on my changes.

add postscriptName param to CustomFontEmbedder.for
Copy link
Author

@matt2023y matt2023y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add postscriptName to CustomFontEmbedder.for

@matt2023y matt2023y closed this Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant