Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ✨ Proposal - Custom transformers #502

Closed
wants to merge 1 commit into from
Closed

feat: ✨ Proposal - Custom transformers #502

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Aug 29, 2022

In progress - early stages

Potential fix for #445 #411

Provides an initial way to implement custom logic for the @pagination and @list resolvers.

If possible, a module based approach would be preferred, allowing the community to extend the base functionality of Hodini with implementations for non standard schemas, for example faunadb.

If possible, it would be best to open a discussion on this topic, as this feature would touch on many other topics(config file, hardcoded values, .etc) and might require a rewrite of the transformers package to accommodate it.

  • If applicable, add a test that would fail without this fix
  • Make sure the unit tests pass locally with pnpm run tests
  • Make sure the integration tests pass locally with cd integration && pnpm run tests
  • Includes a changeset if your fix affects the user with pnpm changeset

@changeset-bot
Copy link

changeset-bot bot commented Aug 29, 2022

⚠️ No Changeset found

Latest commit: 5594b84

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Aug 29, 2022

@DanielHritcu is attempting to deploy a commit to the HoudiniGraphQL Team on Vercel.

A member of the Team first needs to authorize it.

@ghost ghost closed this Aug 29, 2022
@ghost ghost deleted the custom-transformers branch August 29, 2022 04:06
@ghost ghost restored the custom-transformers branch August 29, 2022 04:07
@ghost ghost deleted the custom-transformers branch August 29, 2022 04:07
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants