CSSStyleSheet - several fixes to throw the correct error

HtmlUnit · Feb 3, 2025 · 266e078 · 266e078
1 parent 6241a93
commit 266e078
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 7 deletions.
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
@@ -8,6 +8,9 @@
 
     <body>
         <release version="4.10.0" date="February xx, 2025" description="Bugfixes">
+            <action type="fix" dev="rbri">
+                CSSStyleSheet - several fixes to throw the correct error.
+            </action>
             <action type="fix" dev="rbri">
                 XPath.evaluate() throws a TypeError.
             </action>

diff --git a/src/main/java/org/htmlunit/javascript/host/css/CSSStyleSheet.java b/src/main/java/org/htmlunit/javascript/host/css/CSSStyleSheet.java
@@ -186,10 +186,18 @@ public int insertRule(final String rule, final int position) {
                     return position;
                 }
                 catch (final DOMException ex) {
-                    throw JavaScriptEngine.throwAsScriptRuntimeEx(ex);
+                    throw JavaScriptEngine.asJavaScriptException(
+                            getWindow(),
+                            new org.htmlunit.javascript.host.dom.DOMException(
+                                    ex.getMessage(),
+                                    ex.code));
                 }
             }
-            throw JavaScriptEngine.throwAsScriptRuntimeEx(e);
+            throw JavaScriptEngine.asJavaScriptException(
+                    getWindow(),
+                    new org.htmlunit.javascript.host.dom.DOMException(
+                            e.getMessage(),
+                            e.code));
         }
     }
 
@@ -247,7 +255,11 @@ public void deleteRule(final int position) {
             refreshCssRules();
         }
         catch (final DOMException e) {
-            throw JavaScriptEngine.throwAsScriptRuntimeEx(e);
+            throw JavaScriptEngine.asJavaScriptException(
+                    getWindow(),
+                    new org.htmlunit.javascript.host.dom.DOMException(
+                            e.getMessage(),
+                            e.code));
         }
     }
 

diff --git a/src/test/java/org/htmlunit/javascript/ScriptableObjectTest.java b/src/test/java/org/htmlunit/javascript/ScriptableObjectTest.java
@@ -251,10 +251,10 @@ public void ctorChangeableHasNoEffectForSealed() throws Exception {
      */
     @Test
     @Alerts("true")
-    @HtmlUnitNYI(CHROME = "exception",
-            EDGE = "exception",
-            FF = "exception",
-            FF_ESR = "exception")
+    @HtmlUnitNYI(CHROME = "TypeError",
+            EDGE = "TypeError",
+            FF = "TypeError",
+            FF_ESR = "TypeError")
     public void ctorChangeableHasNoEffectForSealedStrict() throws Exception {
         final String html = "<html><body>\n"
                 + "<script>\n"