NPE in org.htmlunit.javascript.JavaScriptEngine.asJavaScriptException()

HtmlUnit · Feb 11, 2025 · b24a078 · b24a078
1 parent 90032d5
commit b24a078
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
@@ -8,6 +8,9 @@
 
     <body>
         <release version="4.10.0" date="February xx, 2025" description="Chrome/Edge 132, Firefox 135, Javascript Errors, Bugfixes">
+            <action type="fix" dev="rbri">
+                NPE in org.htmlunit.javascript.JavaScriptEngine.asJavaScriptException().
+            </action>
             <action type="update" dev="rbri">
                 Upgrade commons-logging to 1.3.5.
             </action>

diff --git a/src/main/java/org/htmlunit/javascript/JavaScriptEngine.java b/src/main/java/org/htmlunit/javascript/JavaScriptEngine.java
@@ -1213,7 +1213,10 @@ public static RhinoException asJavaScriptException(final HtmlUnitScriptable scop
         domException.setPrototype(scope.getPrototype(DOMException.class));
 
         final EcmaError helper = ScriptRuntime.syntaxError("helper");
-        final String fileName = helper.sourceName().replaceFirst("script in (.*) from .*", "$1");
+        String fileName = helper.sourceName();
+        if (fileName != null) {
+            fileName = fileName.replaceFirst("script in (.*) from .*", "$1");
+        }
         domException.setLocation(fileName, helper.lineNumber());
 
         return new JavaScriptException(domException, fileName, helper.lineNumber());