Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add libretro core support #156

Draft
wants to merge 15 commits into
base: master
Choose a base branch
from
Draft

Conversation

jonian
Copy link

@jonian jonian commented Jul 20, 2024

Hi,

This is the initial implementation of a libretro core as requested in issue #141. It still requires additional work, including screen rotation and cheats support, among other improvements.

Would you be open to accepting the final implementation into the main repository once the core is complete, or would you prefer that I continue development in a separate fork?

Looking forward to your guidance.

@jonian jonian force-pushed the master branch 4 times, most recently from 9f28caf to b1494df Compare July 25, 2024 20:38
@jonian jonian force-pushed the master branch 2 times, most recently from 33b2f78 to d19ac18 Compare July 31, 2024 10:59
@BelleNottelling
Copy link
Contributor

https://github.com/Hydr8gon/NooDS?tab=readme-ov-file#contributing

This is a personal project, and I've decided to not review or accept pull requests for it. If you want to help, you can test things and report issues or provide feedback. If you can afford it, you can also donate to motivate me and allow me to spend more time on things like this. Nothing is mandatory, and I appreciate any interest in my projects, even if you're just a user!

@jonian
Copy link
Author

jonian commented Aug 1, 2024

I have seen that section in the readme but the comment in the issue leaves the possibility open. Maybe I'm understanding something wrong since english is not my native language.

This isn't something that I'd be willing to maintain myself, but someone else could if they wanted to.

Anyway, no pressure to the author/owner of the repository to merge or even comment on this.

@Hydr8gon
Copy link
Owner

Hydr8gon commented Aug 1, 2024

Since this isn't something that I'll be maintaining, I think it should be kept as a separate fork. That said, I don't mind the PR staying open so that people can find it. Nice work, by the way; it's cool to see my project get ported like this!

@jonian
Copy link
Author

jonian commented Aug 1, 2024

Thank you for the kind words! I agree that keeping it in a separate fork is better and I appreciate you leaving the PR open for visibility. I'm still learning about C++, libretro, and emulators, so if you have any suggestions, feel free to comment here or open an issue on my forked repo, if you have time.

@jonian jonian force-pushed the master branch 4 times, most recently from 1ce57d9 to 19530bd Compare August 8, 2024 14:47
@jonian jonian force-pushed the master branch 7 times, most recently from 9127cf5 to f117834 Compare August 8, 2024 15:18
@jonian
Copy link
Author

jonian commented Aug 18, 2024

Hi @Hydr8gon. I have completed porting NooDS to libretro and have asked the libretro/retroarch team to make the core available in the online downloader. I would like to ask you if you are ok with this.

@radicalten
Copy link

radicalten commented Aug 24, 2024

Thank you for your great work here @jonian and @Hydr8gon!

I would also like to notify @saulfabregwiivc about the completion of the libretro core for this project. If he is interested, perhaps he could recompile it to work with a stable version of RA Wii?

Cheers!

@Hydr8gon
Copy link
Owner

Hi @Hydr8gon. I have completed porting NooDS to libretro and have asked the libretro/retroarch team to make the core available in the online downloader. I would like to ask you if you are ok with this.

@jonian Of course, go ahead!

@saulfabregwiivc
Copy link

Thank you for your great work here @jonian and @Hydr8gon!

I would also like to notify @saulfabregwiivc about the completion of the libretro core for this project. If he is interested, perhaps he could recompile it to work with a stable version of RA Wii?

Cheers!

hey, saw i got pinged here, i'll take a look at this project and see if i can modify the Makefile and others for try to compile for Wii.

@saulfabregwiivc
Copy link

@jonian hey there pal, is there any way for add these two platforms Wii and Wii U in Libretro makefile?
I can't figure out how i can add specific platform defines for Libretro makefiles with all its required defines and others (such WIIU).
And i'd like to compile a Wii version of this core for see how it performs.

@ztf147
Copy link

ztf147 commented Oct 22, 2024

Hi @Hydr8gon. I have completed porting NooDS to libretro and have asked the libretro/retroarch team to make the core available in the online downloader. I would like to ask you if you are ok with this.

Do you have a plan to make a Switch build in the future? coz you know on switch we can record past videos for 30 seconds, just better then other mobile platforms i think

@warmenhoven
Copy link

Hi @Hydr8gon, the core is on the libretro buildbot now and currently compiling for android, macOS/iOS/tvOS, windows, and linux. Would you be ok with it being available in the macOS/iOS/tvOS App Store builds?

Also @saulfabregwiivc, the Makefile.libretro now has the beginnings of what's necessary for Wii/WiiU (and Switch as well). There's still a bit more that's necessary for them, and as I'm unfamiliar with their toolchains, I'd appreciate any help you can offer getting them over the finish line.

@Hydr8gon
Copy link
Owner

@warmenhoven oh, cool! I don't have a problem with it being on the App Store, so go ahead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants