Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IRC Protocol Parsing fix #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gdwnldsKSC
Copy link
Contributor

Fixes user modes in channel, topic timestamp parsing, channel modes, and channel creation time parsing on joining for IRCDs that use valid syntax of not putting a space between the : and the last argument of the result/command

UI is properly updating with status (op/voice) channel mode changes now on these networks.

Test run on InspIRCD-3 server that exhibits this behavior:

[22:47] *** now talking in #test908
[22:47] *** channel #test908 mode is +CFTfjntx 5:60 30:5 5:1 :10:5
[22:47] *** channel created at Mon Oct 09 22:47:25 2023
[22:47] *** test12345 changed topic to test
[22:48] *** test32489 (test32489![email protected]) joined
[22:48] *** test12345 sets channel #test908 mode +o test32489

[22:48] *** now talking in #test908
[22:48] *** topic is test
[22:48] *** set by test12345![email protected] on Mon Oct 09 22:47:30 2023
[22:48] *** channel #test908 mode is +CFTfjntx 5:60 30:5 5:1 :10:5
[22:48] *** channel created at Mon Oct 09 22:47:25 2023

This can close #17

@hydra
Copy link
Contributor

hydra commented Dec 17, 2023

can you split up this PR so it just includes the fix and the changes to the readme and make separate PRs for the other changes please.

PR's need to be atomic and focused so they are easy to review.

Fixes user modes in channel, channel modes, and channel creation time parsing on joining for IRCDs that use valid syntax of not putting a space between the : and the last argument of the result/command
@gdwnldsKSC
Copy link
Contributor Author

gdwnldsKSC commented Dec 18, 2023

@hydra cleaned up unrelated license changes, I'll do the whole bulk license change as one PR. Note about .168 was omitted from the update it was in, FYI.

Might be a good idea running this through a formatter at some point for consistency once it's VS2012+. You'll have to let me know if you have any preferred standards for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IRC protocol bug with colon escaping of last argument
2 participants