Skip to content

Commit

Permalink
Don't mention experimental resume run feature in every run monitoring…
Browse files Browse the repository at this point in the history
… failure message (dagster-io#24541)

Summary:
Noticed this while testing something involving run monitoring. This
feature is experimental and should only be refernced if the user has
done something to enable it.

Test Plan: BK

## Summary & Motivation

## How I Tested These Changes

## Changelog

Insert changelog entry or "NOCHANGELOG" here.

- [ ] `NEW` _(added new feature or capability)_
- [ ] `BUGFIX` _(fixed a bug)_
- [ ] `DOCS` _(added or updated documentation)_
  • Loading branch information
gibsondan authored Sep 17, 2024
1 parent 80d170d commit 025390f
Showing 1 changed file with 4 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,10 @@ def monitor_started_run(
# Return rather than immediately checking for a timeout, since we only just resumed
return
else:
if instance.run_launcher.supports_resume_run:
if (
instance.run_launcher.supports_resume_run
and instance.run_monitoring_max_resume_run_attempts > 0
):
msg = (
f"Detected run worker status {check_health_result}. Marking run"
f" {run.run_id} as failed, because it has surpassed the configured maximum"
Expand Down

0 comments on commit 025390f

Please sign in to comment.