Refactoring UserIdentity logics #1097
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunnywu
changed the base branch from
syw-UID2-4159-token-gen-code-refactoring
to
syw-UID2-4159-token-gen-code-renaming
sunnywu
changed the base branch from
syw-UID2-4159-token-gen-code-renaming
to
syw-UID2-4159-token-gen-code-refactoring
sunnywu
changed the base branch from
syw-UID2-4159-token-gen-code-refactoring
to
syw-UID2-4159-token-gen-code-renaming
| @@ -3,6 +3,9 @@ | |||
|
|
|||
| public class PrivacyBits { | |||
|
|
|||
| // For historical reason this bit is set | |||
| public static final int DEFAULT_PRIVACY_BIT_VALUE = 1; | |||
There was a problem hiding this comment.
Maybe this should be PrivacyBits instead?
public static final PrivacyBits DEFAULT = PrivacyBits.fromInt(1);There was a problem hiding this comment.
removed all uses of int PrivacyBits and use PrivacyBits class instead. Added unit tests to test the class
sunnywu
force-pushed
the
syw-UID2-4159-token-gen-code-refactoring-UserIdentity
branch
from
78a70d4 to
a8f0915
Compare
…-application Runtime config retrieval and application
…b589b79605ca602 [CI Pipeline] Released Minor version: 5.46.0
…f59fa469241a184 [CI Pipeline] Released Minor version: 5.47.0
- retrieve `useDynamicConfig` toggle from correct location in feat-flag.json file
* Update to fix new config errors, change exception name
…nitialisation fails
…ndling Fail operator start up if ConfigService initialisation fails
- change default to feat flag off
- remove unused const - add comment for json structure
…listener Fix feat flag listener
…298854f5e1bdc50 [CI Pipeline] Released Patch version: 5.50.12
Updated E2E test pipeline
Updated run E2E pipeline target description
Fixed AWS Makefile
removing all old sdk tracking code except for version 2
Reverted target_environment description change
extended trivyignore for CVE-2024-8176 and CVE-2025-24970
- Add error checking.
- Fix path to generate.py.
- Some sed commands should have been on ${INPUT_DIR}/generated.rego.
- Collapse multiple sed commands into one for simpler error checking.
…e-id Fix AKS enclave ID
* Re-adding encryption, flag to toggle. ---- Co-authored-by: Release Workflow <[email protected]> Co-authored-by: Vishal Egbert <[email protected]>
https://github.com/IABTechLab/uid2-operator into syw-UID2-4159-token-gen-code-refactoring-UserIdentity
…en-code-refactoring-UserIdentity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tokenvariable names to adTokenInput and refreshTokenInput to make it clearer