Warn Publishers when removing sharing with DSP during recommendations flow #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix styling
Completing recommendations used to re-populate the local participant context with the types from the portal, rather than the source of truth types from admin. This fix just refetches the participant with the source of truth types, instead of just relying on the portal db.
ssundahlTTD
approved these changes
Nov 17, 2023
alex-yau-ttd
deleted the
ajy-UID2-1936-Warn-pubs-against-bulk-removing-dsps-during-recommendations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had previously implemented this banner once the participant had already completed the recommendations flow, but this PR implements it during the recommendations flow.
I also fixed two bugs which I noticed during development:
Banner shows at the wrong time
Before
Note the participant type changes to "DSP" after completing the recommendations. Hence why the warning does not show when unchecking DSP after completing recommendations, because the participant does not appear to be a Publisher.
After
I've also added unit tests for
publisherHasUncheckedDSPCompleting the recommendations changes the participant types
Before
chrome_2QjTOtExdk.mp4
After
chrome_LzwBN46xDJ.mp4