Utilize new route for admin to just collect 1 site #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that admin will need to deployed with the changes in IABTechLab/uid2-admin#184 before this gets deployed. Let's hold off on merging until then. Could you please also add a step to |
lionell-pack-ttd
approved these changes
Dec 6, 2023
alex-yau-ttd
reviewed
Dec 6, 2023
| @@ -13,6 +13,7 @@ Don't delete old sections - just leave them towards the bottom of the file, and | |||
| ## Next (pending changes for the next coming release) | |||
|
|
|||
| 1. Admin must be deployed before the portal to include the Role changes needed for setting client types (sas-UID2-1782-approved-types-to-admin) | |||
| 2. Admin must be deployed before the portal to include the Get Site By Id endpoint utilized (jss-UID2-2065-get-site-by-id) | |||
There was a problem hiding this comment.
It might be a good idea to move these down, since admin is already deployed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Frontend changes to utilize new admin api call.
Linked to admin pr: IABTechLab/uid2-admin#184