List participant on management page #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-yau-ttd
reviewed
Dec 6, 2023
src/web/components/ParticipantRequests/ApprovedParticipantItem.tsx
Outdated
Show resolved
Hide resolved
alex-yau-ttd
reviewed
Dec 6, 2023
alex-yau-ttd
reviewed
Dec 6, 2023
ssundahlTTD
reviewed
Dec 6, 2023
src/web/components/ParticipantRequests/ApprovedParticipantsTable.tsx
Outdated
Show resolved
Hide resolved
src/web/components/ParticipantRequests/ApprovedParticipantItem.tsx
Outdated
Show resolved
Hide resolved
|
Could you please include a screenshot of the new UI :D |
|
|
can you please put it in the MR description instead so it's easier to find |
alex-yau-ttd
reviewed
Dec 6, 2023
src/web/components/ParticipantRequests/ApprovedParticipantsTable.tsx
Outdated
Show resolved
Hide resolved
alex-yau-ttd
reviewed
Dec 6, 2023
src/web/components/ParticipantRequests/ApprovedParticipantsTable.stories.tsx
Outdated
Show resolved
Hide resolved
alex-yau-ttd
reviewed
Dec 6, 2023
src/web/components/ParticipantRequests/ApprovedParticipantsTable.stories.tsx
Outdated
Show resolved
Hide resolved
alex-yau-ttd
reviewed
Dec 7, 2023
| @@ -30,6 +30,7 @@ export function ParticipantRequestsTable({ | |||
| }: ParticipantRequestsTableProps) { | |||
| return ( | |||
| <div className='participant-requests-container'> | |||
| <h2>{participantRequests.length} Participants Pending Approval</h2> | |||
There was a problem hiding this comment.
Let's conditionally render the string to be singular when there is only one participantRequest to avoid
alex-yau-ttd
reviewed
Dec 7, 2023
| participantTypes={participantTypes} | ||
| onApprove={handleApproveParticipantRequest} | ||
| /> | ||
| <div> |
There was a problem hiding this comment.
nit: I'd recommend just using <> here instead of a <div>. I think it ends up being a <div> in the DOM anyway but it reads a bit cleaner. You'd want to use <div> if it was being used for styling.
alex-yau-ttd
approved these changes
Dec 7, 2023
joshua-smee-ttd
deleted the
jss-UID2-1612-list-existing-participants-manage-screen
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added list of Approved Participants to the management screen.