manage participants screen improvements #584
Conversation
|
|
||
| export async function down(knex: Knex): Promise<void> { | ||
| await knex.schema.alterTable('participants', (table) => { | ||
| table.enu('status', ['initialize', 'awaitingApproval', 'approved']); |
There was a problem hiding this comment.
should i leave this as is which sets all values to null or should i set all rows to 'approved'
There was a problem hiding this comment.
probably set them all to approved. I don't think the UI is expecting a null approval status.
| const result = participants.sort((a, b) => a.name.localeCompare(b.name)); | ||
| return res.status(200).json(result); | ||
| }; | ||
|
|
There was a problem hiding this comment.
Renamed and moved over from participantsApproval.ts
| import { SiteDTO } from '../../../api/services/adminServiceHelpers'; | ||
| import { HighlightedResult } from './ParticipantApprovalForm'; | ||
| import { SiteDTO } from '../../../../api/services/adminServiceHelpers'; | ||
| import { HighlightedResult } from './HighlightedResult'; |
There was a problem hiding this comment.
not sure why this component was housed in ParticipantApprovalForm but moved it to its own file since we are deleting ParticipantApprovalForm anyways
src/web/services/participant.ts
Outdated
| @@ -283,20 +266,3 @@ export type ParticipantApprovalFormDetails = { | |||
| apiRoles: number[]; | |||
There was a problem hiding this comment.
Can we remove this too? ParticipantApprovalFormDetails
There was a problem hiding this comment.
yeah nice catch!
|
|
||
| export async function down(knex: Knex): Promise<void> { | ||
| await knex.schema.alterTable('participants', (table) => { | ||
| table.enu('status', ['initialize', 'awaitingApproval', 'approved']); |
There was a problem hiding this comment.
probably set them all to approved. I don't think the UI is expecting a null approval status.
| }; | ||
|
|
||
| type HighlightedResultProps = Readonly<{ | ||
| result: Fuse.FuseResult<SiteDTO>; |
There was a problem hiding this comment.
This core component shouldn't have a dependency on a specific data type. Should be able to make this generic.
There was a problem hiding this comment.
Generalized it
ashleysmithTTD
deleted the
ans-UID2-4200-manage-participants-screen-improvements
branch
What Changed:
dbo.participantssince all participants were defaulting to approved nowawaitingApprovalstatusParticipantStatusgetApprovedParticipantstogetAllParticipantsHighlightedResultinto its own component fileApprovedParticipantsTabletoParticipantManagementTableAuditTrailTable)Test Plan: