Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for h100 cluster, instance and template changes #5776

Merged
merged 4 commits into from
Nov 27, 2024
Merged

Added support for h100 cluster, instance and template changes #5776

merged 4 commits into from
Nov 27, 2024

Conversation

uibm
Copy link
Collaborator

@uibm uibm commented Nov 8, 2024 •
edited
Loading

Features

  • Cluster(h100) support for VPC infrastructure services

    • Datasources

      • ibm_is_cluster_network
      • ibm_is_cluster_network_interface
      • ibm_is_cluster_network_interfaces
      • ibm_is_cluster_network_profile
      • ibm_is_cluster_network_profiles
      • ibm_is_cluster_network_subnet
      • ibm_is_cluster_network_subnet_reserved_ip
      • ibm_is_cluster_network_subnet_reserved_ips
      • ibm_is_cluster_network_subnets
      • ibm_is_cluster_networks
      • ibm_is_instance
      • ibm_is_instance_cluster_network_attachment
      • ibm_is_instance_cluster_network_attachments
      • ibm_is_instance_profile
      • ibm_is_instance_profiles
      • ibm_is_instance_template
      • ibm_is_instance_templates
      • ibm_is_instances

    • Resources

      • ibm_is_cluster_network
      • ibm_is_cluster_network_interface
      • ibm_is_cluster_network_subnet
      • ibm_is_cluster_network_subnet_reserved_ip
      • ibm_is_instance
      • ibm_is_instance_cluster_network_attachment
      • ibm_is_instance_template

Changes in datasource :

  • cluster_network_profile
    • code
    • test
    • doc
% make testacc TEST=./ibm/service/vpc TESTARGS='-run=TestAccIBMIsClusterNetworkProfileDataSourceBasic'
=== RUN   TestAccIBMIsClusterNetworkProfileDataSourceBasic
--- PASS: TestAccIBMIsClusterNetworkProfileDataSourceBasic (22.57s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     24.571s
  • cluster_network_profiles
    • code
    • test
    • doc
% make testacc TEST=./ibm/service/vpc TESTARGS='-run=TestAccIBMIsClusterNetworkProfilesDataSourceBasic'
=== RUN   TestAccIBMIsClusterNetworkProfilesDataSourceBasic
--- PASS: TestAccIBMIsClusterNetworkProfilesDataSourceBasic (19.99s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     22.089s
  • cluster_network
    • code
    • test
    • doc
% make testacc TEST=./ibm/service/vpc TESTARGS='-run=TestAccIBMIsClusterNetworkDataSourceBasic'
=== RUN   TestAccIBMIsClusterNetworkDataSourceBasic
--- PASS: TestAccIBMIsClusterNetworkDataSourceBasic (20.74s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     22.812s
  • cluster_networks
    • code
    • test
    • doc
% make testacc TEST=./ibm/service/vpc TESTARGS='-run=TestAccIBMIsClusterNetworksDataSourceBasic'
=== RUN   TestAccIBMIsClusterNetworksDataSourceBasic
--- PASS: TestAccIBMIsClusterNetworksDataSourceBasic (17.16s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     19.167s
  • cluster_networks_interface
    • code
    • test
    • doc
% make testacc TEST=./ibm/service/vpc TESTARGS='-run=TestAccIBMIsClusterNetworkInterfaceDataSourceBasic'
=== RUN   TestAccIBMIsClusterNetworkInterfaceDataSourceBasic
--- PASS: TestAccIBMIsClusterNetworkInterfaceDataSourceBasic (12.88s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     14.878s
  • cluster_networks_interfaces
    • code
    • test
    • doc
% make testacc TEST=./ibm/service/vpc TESTARGS='-run=TestAccIBMIsClusterNetworkInterfacesDataSourceBasic'
=== RUN   TestAccIBMIsClusterNetworkInterfacesDataSourceBasic
--- PASS: TestAccIBMIsClusterNetworkInterfacesDataSourceBasic (14.83s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     16.657s
  • cluster_networks_subnet
    • code
    • test
    • doc
% make testacc TEST=./ibm/service/vpc TESTARGS='-run=TestAccIBMIsClusterNetworkSubnetDataSourceBasic'  
=== RUN   TestAccIBMIsClusterNetworkSubnetDataSourceBasic
--- PASS: TestAccIBMIsClusterNetworkSubnetDataSourceBasic (17.80s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     19.792s
  • cluster_networks_subnets
    • code
    • test
    • doc
% make testacc TEST=./ibm/service/vpc TESTARGS='-run=TestAccIBMIsClusterNetworkSubnetsDataSourceBasic'
=== RUN   TestAccIBMIsClusterNetworkSubnetsDataSourceBasic
--- PASS: TestAccIBMIsClusterNetworkSubnetsDataSourceBasic (25.68s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     29.578s
  • cluster_network_subnet_reserved_ip
    • code
    • test
    • doc
% make testacc TEST=./ibm/service/vpc TESTARGS='-run=TestAccIBMIsClusterNetworkSubnetReservedIPDataSourceBasic'    
=== RUN   TestAccIBMIsClusterNetworkSubnetReservedIPDataSourceBasic
--- PASS: TestAccIBMIsClusterNetworkSubnetReservedIPDataSourceBasic (20.24s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     22.213s
  • cluster_network_subnet_reserved_ips
    • code
    • test
    • doc
 % make testacc TEST=./ibm/service/vpc TESTARGS='-run=TestAccIBMIsClusterNetworkSubnetReservedIpsDataSourceBasic'
=== RUN   TestAccIBMIsClusterNetworkSubnetReservedIpsDataSourceBasic
--- PASS: TestAccIBMIsClusterNetworkSubnetReservedIpsDataSourceBasic (18.99s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     20.963s
  • cluster_network_attachment
    • code
    • test
    • doc
% make testacc TEST=./ibm/service/vpc TESTARGS='-run=TestAccIBMIsInstanceClusterNetworkAttachmentDataSourceAllArgs'
=== RUN   TestAccIBMIsInstanceClusterNetworkAttachmentDataSourceAllArgs
--- PASS: TestAccIBMIsInstanceClusterNetworkAttachmentDataSourceAllArgs (21.33s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     23.010s
  • cluster_network_attachments
    • code
    • test
    • doc
% make testacc TEST=./ibm/service/vpc TESTARGS='-run=TestAccIBMIsInstanceClusterNetworkAttachmentsDataSourceAllArgs'
=== RUN   TestAccIBMIsInstanceClusterNetworkAttachmentsDataSourceAllArgs
--- PASS: TestAccIBMIsInstanceClusterNetworkAttachmentsDataSourceAllArgs (22.46s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     24.412s
  • instance_profile
    • code
    • test
    • doc
% make testacc TEST=./ibm/service/vpc TESTARGS='-run=TestAccIBMISInstanceProfileDataSource_cluster'
=== RUN   TestAccIBMISInstanceProfileDataSource_cluster
--- PASS: TestAccIBMISInstanceProfileDataSource_cluster (16.97s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     18.853s
  • instance_profiles
    • code
    • test
    • doc
% make testacc TEST=./ibm/service/vpc TESTARGS='-run=TestAccIBMISInstanceProfileDataSource_cluster'
--- PASS: TestAccIBMISInstanceProfileDataSource_cluster (16.97s)
--- PASS: TestAccIBMISInstanceProfilesDataSource_cluster (31.36s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     33.120s
  • instance_template
    • code
    • test
    • doc
% make testacc TEST=./ibm/service/vpc TESTARGS='-run=TestAccIBMISInstanceTemplateDatasourceCluster'  
=== RUN   TestAccIBMISInstanceTemplateDatasourceCluster
--- PASS: TestAccIBMISInstanceTemplateDatasourceCluster (22.68s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     24.612s
  • instance_templates
    • code
    • test
    • doc
% make testacc TEST=./ibm/service/vpc TESTARGS='-run=TestAccIBMISInstanceTemplatesDataSourceCluster'
=== RUN   TestAccIBMISInstanceTemplatesDataSourceCluster
--- PASS: TestAccIBMISInstanceTemplatesDataSourceCluster (21.17s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     23.126s
  • instance
    • code
    • test
    • doc
% make testacc TEST=./ibm/service/vpc TESTARGS='-run=TestAccIBMISInstanceDS_BasicCluster'
=== RUN   TestAccIBMISInstanceDS_BasicCluster
--- PASS: TestAccIBMISInstanceDS_BasicCluster (32.28s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     34.145s
  • instances
    • code
    • test
    • doc
 % make testacc TEST=./ibm/service/vpc TESTARGS='-run=TestAccIBMISInstancesDS_basicCluster'
=== RUN   TestAccIBMISInstancesDS_basicCluster
--- PASS: TestAccIBMISInstancesDS_basicCluster (30.69s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     32.646s

Changes in resource :

  • cluster_networks
    • code
    • test
    • doc
% make testacc TEST=./ibm/service/vpc TESTARGS='-run=TestAccIBMIsClusterNetworkBasic'
=== RUN   TestAccIBMIsClusterNetworkBasic
--- PASS: TestAccIBMIsClusterNetworkBasic (67.20s)

=== RUN   TestAccIBMIsClusterNetworkBasicAllArgs
--- PASS: TestAccIBMIsClusterNetworkBasicAllArgs (101.58s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     170.876s
  • cluster_network_interfaces
    • code
    • test
    • doc
% make testacc TEST=./ibm/service/vpc TESTARGS='-run=TestAccIBMIsClusterNetworkInterfaceBasic'
=== RUN   TestAccIBMIsClusterNetworkInterfaceBasic
--- PASS: TestAccIBMIsClusterNetworkInterfaceBasic (73.66s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     75.804s
  • cluster_network_subnets
    • code
    • test
    • doc
% make testacc TEST=./ibm/service/vpc TESTARGS='-run=TestAccIBMIsClusterNetworkSubnetBasic'
=== RUN   TestAccIBMIsClusterNetworkSubnetBasic
--- PASS: TestAccIBMIsClusterNetworkSubnetBasic (66.31s)
=== RUN   TestAccIBMIsClusterNetworkSubnetBasicAllArgs
--- PASS: TestAccIBMIsClusterNetworkSubnetBasicAllArgs (106.35s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     174.488s
  • cluster_network_subnets_reserved_ips
    • code
    • test
    • doc
 % make testacc TEST=./ibm/service/vpc TESTARGS='-run=TestAccIBMIsClusterNetworkSubnetReservedIPBasic'
=== RUN   TestAccIBMIsClusterNetworkSubnetReservedIPBasic
--- PASS: TestAccIBMIsClusterNetworkSubnetReservedIPBasic (72.40s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     74.110s
  • cluster_network_attachments
    • code
    • test
    • doc
  • instance_template
    • code
    • test
    • doc
% make testacc TEST=./ibm/service/vpc TESTARGS='-run=TestAccIBMISInstanceTemplate_clusternetworkbasic'
=== RUN   TestAccIBMISInstanceTemplate_clusternetworkbasic
--- PASS: TestAccIBMISInstanceTemplate_clusternetworkbasic (97.80s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     99.749s
  • instance
    • code
    • test
    • doc

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@uibm uibm requested a review from hkantare November 21, 2024 04:13
hkantare
hkantare previously approved these changes Nov 26, 2024
View reviewed changes
@uibm uibm requested a review from hkantare November 26, 2024 14:57
@uibm
Copy link
Collaborator Author

uibm commented Nov 26, 2024

@hkantare resolved the conflicts

@hkantare hkantare merged commit e068524 into IBM-Cloud:master Nov 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkantare hkantare hkantare approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uibm @hkantare