Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for volume_prototypes on ibm_is_instance resource #5777

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

ujjwal-ibm
Copy link
Collaborator

@ujjwal-ibm ujjwal-ibm commented Nov 8, 2024

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

% make testacc TEST=./ibm/service/vpc TESTARGS='-run=TestAccIBMISInstance_volprototypes'
=== RUN   TestAccIBMISInstance_volprototypes
--- PASS: TestAccIBMISInstance_volprototypes (310.98s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     312.985s

@ujjwal-ibm ujjwal-ibm marked this pull request as draft November 8, 2024 07:58
@ujjwal-ibm ujjwal-ibm marked this pull request as ready for review November 19, 2024 04:24
@ujjwal-ibm
Copy link
Collaborator Author

% make testacc TEST=./ibm/service/vpc TESTARGS='-run=TestAccIBMISInstance_volprototypes'
=== RUN   TestAccIBMISInstance_volprototypes
--- PASS: TestAccIBMISInstance_volprototypes (377.61s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     379.327s

@ujjwal-ibm
Copy link
Collaborator Author

% make testacc TEST=./ibm/service/vpc TESTARGS='-run=TestAccIBMISInstance_basic'                            
=== RUN   TestAccIBMISInstance_basic
--- PASS: TestAccIBMISInstance_basic (255.09s)
=== RUN   TestAccIBMISInstance_basicwithipv4
--- PASS: TestAccIBMISInstance_basicwithipv4 (145.29s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     402.563s

@hkantare hkantare merged commit e900f65 into IBM-Cloud:master Nov 26, 2024
1 check passed
@ujjwal-ibm ujjwal-ibm deleted the ins-vol-att branch November 27, 2024 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants