remove ip package dependency #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: saikumar1607 <[email protected]>
ibm-cloud-appconfiguration
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IP package has vulnerability - indutny/node-ip#150 and no patch is provided yet GHSA-2p57-rm9w-gvfp
This PR removes the dependency from the
ippackage and implements the internet check logic usingdns-socketpackage. With this new code changes the "internet disconnect" usecase is retested manually and verified that it works the same way as earlier. (i.e., the SDK reestablishes a new websocket connection & force fetches the latest feature flag values once the internet connectivity is back)Patch version of the SDK is bumped. The new release version is v0.7.6