[1주차] 기본/도전 과제 제출 #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkyu0718
reviewed
Oct 7, 2022
m1njae
reviewed
Oct 7, 2022
| interface Dinner { | ||
| members: SoptMember[]; | ||
| shuffle: (members: SoptMember[]) => SoptMember[]; | ||
| organize: (members: SoptMember[]) => void; |
There was a problem hiding this comment.
진짜 오늘 일찍 봤는데 arrow function으로 타입지정을 해주신거 보고 궁금증이 생겨서 찾아보고 오다가 코드리뷰가 늦었습니다.. 어떤 궁금증인지 궁금하시다면 꿀팁/자료 아카이빙에 적어놨으니 많관부.!
There was a problem hiding this comment.
확인했습니다! 코틀린 사용할 때 습관이었어요!
m1njae
reviewed
Oct 7, 2022
| organize(array) { | ||
| this.shuffle(array); | ||
|
|
||
| for (let i = 0; i < this.members.length; i = i + 2) { |
There was a problem hiding this comment.
for만 보면 무조건 javascript스러운 forEach(), map 무새였는데 수현님 코드보다가
단순반복을 위해 for를 활용해주셨구나~를 깨달았습니다 크크
단순 반복이라면 for( ), 배열을 순회하려면 forEach( ), 배열을 순회 후 새 배열을 얻고 싶다면 map( ) 사용할 것을 권장한다고 하네요!
코드 리뷰 하면서 또 배웠어요ㅎㅅㅎ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SERVER PR
🐕 과제 구현 명세
interfaceSoptMember, Dinner를 만들었고, 짝수명의 멤버가 있다는 가정 하에 2명씩 짝을 지을 수 있도록 구현했습니다.🐥 이런 점이 새로웠어요 / 어려웠어요