[2주차] 기본/도전 과제 제출 #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m1njae
reviewed
Oct 13, 2022
| const router: Router = express.Router(); | ||
|
|
||
| router.get("/", (req: Request, res: Response) => { | ||
| const blog: Object = { |
There was a problem hiding this comment.
작성해주신 것처럼 Object는 모든 객체가 할당이 될 수 있습니다:) 어떻게 보면 any와 같을 수도 있겠네요! 그렇지만 Object를 타입으로 정의하는 경우 타입 검사에 엄격한 TypeScript를 사용하는 의도가 모호해질 수도 있다는 생각이 들었어요😢
객체의 타입을 명확하게 정의하기 위해서 1차세미나에서 배웠던 interface를 활용해보는 건 어떨까용?
There was a problem hiding this comment.
interface로 쓸 생각을 못했네요! 추후에 수정하겠습니다!
m1njae
reviewed
Oct 13, 2022
m1njae
reviewed
Oct 13, 2022
| }); | ||
| }); | ||
|
|
||
| module.exports = router; |
There was a problem hiding this comment.
파일 마지막에 빨간색 금지 표지판같이 생긴거 보이시나욥?
파일의 끝엔 EOF 라고 개행문자를 추가하는게 좋습니다!
참고하면 좋을거 같아요 !
vscode에서 개행 추가하는 방법은 다음과 같습니다!
kkyu0718
reviewed
Oct 14, 2022
| title: "글 제목", | ||
| writer: "곰돌이", | ||
| content: "글 내용~", | ||
| isLike: true, |
There was a problem hiding this comment.
blog 타입 선언을 Object라고 해도 되긴 하지만 나중에 더 자세히 선언하실거면 interface를 만들어서 타입 지정을 해도 좋을거 같습니당
곰돌이~ 귀여워용 ㅎㅎㅎ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SERVER PR
🐕 과제 구현 명세
🐥 이런 점이 새로웠어요 / 어려웠어요