Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Milestone/Project 3: associations 🎫 #3

Merged
merged 5 commits into from
Nov 9, 2023

Conversation

ITurres
Copy link
Owner

@ITurres ITurres commented Nov 9, 2023

🚩I have made the following changes to complete OOP School Library - Milestone/Project 3

Here is a summary of what has been done

Type of files added / changed

My Skills

In this new Branch, I have βž•ADDEDβž• the succeeding *πŸ“‚ folders and/or **πŸ“„ files to complete this milestone's requirements

*πŸ“‚ root/

  • *πŸ“‚ lib/

    • **πŸ“„ book.rb βž•
    • **πŸ“„ rental.rb βž•
    • **πŸ“„ classroom.rb βž•

I have ✏️MODIFIED✏️ the succeeding *πŸ“‚ folders and/or πŸ“„** files

*πŸ“‚ root/

  • **πŸ“„ README.md ✏️

    • I have marked as complete the 'Associations' item on Future Features section.
  • *πŸ“‚ lib/

    • **πŸ“„ person.rb ✏️

      • The -Person- class was modified to be part of the many-to-many and has-many-through associations with the -Rental- and -Book- classes.
    • **πŸ“„ student.rb ✏️

      • I had established a bidirectional association: Student adds to -Classroom-,
        and -Classroom- assigns to Student.

Thank you for taking the time to review this PR ⭐


If you require additional information or have any questions, don't hesitate to get in touch with me on Slack as Arturo (Arthur) Emanuel Guerra Iturres. I'll be happy to help you out. 🎯


@ITurres ITurres added documentation Improvements or additions to documentation enhancement New feature or request labels Nov 9, 2023
@ITurres ITurres self-assigned this Nov 9, 2023
Copy link

@Davidosky007 Davidosky007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ITurres πŸ‘‹,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! πŸŽ‰

Highlights

  • Association between classes setup properly πŸ‘
  • Well-written PR πŸ‘
  • No linter errors πŸ‘

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will improve your application.

Cheers and Happy coding!πŸ‘πŸ‘πŸ‘

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@ITurres
Copy link
Owner Author

ITurres commented Nov 9, 2023

Hey @Davidosky007! David Good to see you again! thank you for having reviewed the PR πŸ™πŸΌ. Cheers, and a blessed week!

@ITurres ITurres merged commit 7815f4c into development Nov 9, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants