Skip to content

Commit

Permalink
Fix integration tests connect minio (#20)
Browse files Browse the repository at this point in the history
* Trying to add ports to integration.yml

* add minio arguments to start server

* fix yaml whitespace

* change image to bitnami/minio

* add curl to check minio is up

* retrun fix-integration-tests-connect-mini to branches

* try change minio adress to localhost

* remove fix-integration-tests-connect-minio

* add more docs

* remove Authorization header

* remove curl command, cause problems sometimes

Co-authored-by: menas <[email protected]>
  • Loading branch information
menishmueli and menas authored Oct 15, 2020
1 parent bc7d3e7 commit 8b0b54e
Showing 1 changed file with 8 additions and 2 deletions.
10 changes: 8 additions & 2 deletions .github/workflows/integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,16 @@ jobs:

services:
minio:
image: minio/minio
# Not using official minio image minio/minio because it requires arguments (start /data)
# and github actions currently not supporting docker araguments
# bitnami/minio image has 1M+ pulls and is up to date so it's should be OK to use it
image: bitnami/minio
env:
MINIO_ACCESS_KEY: administrator
MINIO_SECRET_KEY: administrator
ports:
- 9000:9000
options: --name minio-server

steps:
- uses: actions/checkout@v2
Expand All @@ -40,6 +46,6 @@ jobs:
- name: integration tests
run: pytest
env:
MINIO_TEST_CONNECTION: minio:9000
MINIO_TEST_CONNECTION: localhost:9000
MINIO_TEST_ACCESS_KEY: administrator
MINIO_TEST_SECRET_KEY: administrator

0 comments on commit 8b0b54e

Please sign in to comment.