Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JsonRpcConnection#Disconnect(): wait for #WriteOutgoingMessages() after cancelling I/O #10219

Closed
wants to merge 1 commit into from
Closed

JsonRpcConnection#Disconnect(): wait for #WriteOutgoingMessages() after cancelling I/O #10219

wants to merge 1 commit into from

Commits on Nov 7, 2024

  1. JsonRpcConnection#Disconnect(): wait for #WriteOutgoingMessages() aft… 

    …er cancelling I/O

While #Disconnect() is running in foreground on #m_IoStrand, #WriteOutgoingMessages() could wait for #m_OutgoingMessagesQueued or, theoretically, pending I/O. Also cancelling such I/O makes sense, to wake up #WriteOutgoingMessages() first if necessary.
    @Al2Klimov
    Al2Klimov authored Nov 7, 2024
    Configuration menu
    Copy the full SHA
    94067db View commit details
    Browse the repository at this point in the history