Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checkable: Don't skip redundancy group checks for parent dependencies #10228

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Checkable: Don't skip redundancy group checks for parent dependencies #10228

wants to merge 1 commit into from

Commits on Nov 27, 2024

  1. Checkable: Don't skip redundancy group checks for parent dependencies 

    Previously, all parent dependencies were recursively checked right at
the beginning of `Checkable::IsReachable()` for reachability and
immediately returned `false` if one of them fails. However, since the
introduction of `redundancy_group`, that failed parent might be within a
redundancy group, which shouldn't necessarily cause the dependency to
fail completely. This PR changes this insofar as not all parents are
checked at the beginning of the method, but only a single parent per
a dependency object is evaluated.
    @yhabteab
    yhabteab committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    d7936cd View commit details
    Browse the repository at this point in the history