Add a move bar widget #1627
Add a move bar widget #1627
Conversation
|
For reference, this is how the bar looks like |
|
I fixed an error in the XML file that was preventing the navigation url bar being shown while in not curved mode |
|
I think that the move bar is still visible in resize mode, but it can not be used. It should probably be hidden in that case. |
I have tried and it is not visible, so working as expected. That said I found a weird bug. When putting a standard YT video in fullscreen mode and then unfullscreening it, the move bar dissapears from the front window. It's shown in the others but not in the front one. I'm checking. |
The bug was not caused by the patch, but unveiled instead. I've included a commit that fixes it. |
app/src/common/shared/com/igalia/wolvic/ui/widgets/NavigationBarWidget.java
Outdated
Show resolved
Hide resolved
|
@felipeerias it'd be nice if you could take another look to this |
|
@svillar I think that this is almost ready, great job! One issue is that the alpha of the view is set to MIN when the user clicks on it. I think that this might be caused by some interaction between the hover and touch events. How about keeping alpha the same and changing the background of the move bar in response to different events? Something like this: ScreenRecording_2024.11.29-12.26.04.mp4
<View
android:layout_width="@dimen/move_bar_width"
android:layout_height="8dp"
android:layout_gravity="center"
android:background="@drawable/move_bar_background"
android:duplicateParentState="true"
android:radius="4dp" />
<selector xmlns:android="http://schemas.android.com/apk/res/android">
<item android:state_pressed="true">
<shape>
<solid android:color="@color/ocean" />
<corners android:radius="5dp" />
<size android:height="5dp" />
<!-- 50% opacity @color/asphalt -->
<stroke android:width="1dp" android:color="#3d3d3d80" />
</shape>
</item>
<item android:state_hovered="true">
<shape>
<solid android:color="@color/azure" />
<corners android:radius="5dp" />
<size android:height="5dp" />
<stroke android:width="1dp" android:color="#3d3d3d80" />
</shape>
</item>
<item>
<shape>
<solid android:color="@color/fog" />
<corners android:radius="5dp" />
<size android:height="5dp" />
<stroke android:width="1dp" android:color="#3d3d3d80" />
</shape>
</item>
</selector>The colors are just an example, but I think that it would be a good idea to use a similar color scheme to #1647 for consistency. |
Yes you're right. The problem is that we receive the hover exit event just before the touch down event is emitted. We cannot know at that point whether the hover exit was emitted because the pointer moved away or because a touch down event is about to arrive.
The video looks good, I'll follow that suggestion. |
This widget replaces the experimental move windows button that could be enabled from the Display Settings. That button was shown in the navigation bar and was a bit weird to use. This PR replaces it with a thing semi-transparent bar that when dragged moves the window in the horizontal direction as the old button used to do. That bar is unconditionally shown when in curved mode.
Window view model's isCurved property was not properly updated when exiting fullscreen. When entering fullscreen it's updated because placeWindow() is called. However on unfullscreen placeWindow() is not called so the isCurved property was not updated. The solution is to call updateCurvedMode when entering/exiting fullscreen.
This widget replaces the experimental move windows button that could be enabled from the Display Settings. That button was shown in the navigation bar and was a bit weird to use.
This PR replaces it with a thing semi-transparent bar that when dragged moves the window in the horizontal direction as the old button used to do. That bar is unconditionally shown when in curved mode.