Zhani/adapt new backend api #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhani
force-pushed
the
zhani/adapt_new_backend_api
branch
from
44b60cd
to
5e7929c
Compare
neodesys
previously approved these changes
Oct 26, 2023
There was a problem hiding this comment.
Take special care at your destructors declaration. If a class is not final it can be inherited and then its destructor must be virtual else you will have border effects at destruction time.
A good rule is:
- if you design your class to not be inherited, set the class
finalwith a non-virtual destructor - if you don't set your class
final(because you want to inherit from it or you're not sure if one day somebody is going to inherit from it) then your destructor must bevirtual
zhani
force-pushed
the
zhani/adapt_new_backend_api
branch
from
5e7929c
to
595371c
Compare
neodesys
previously approved these changes
Nov 7, 2023
zhani
force-pushed
the
zhani/adapt_new_backend_api
branch
4 times, most recently
from
b9f5531
to
ca17083
Compare
New WPEBackend-android API introduces sync fence which is used when posting buffers to surface control
zhani
force-pushed
the
zhani/adapt_new_backend_api
branch
from
ca17083
to
4e192b2
Compare
neodesys
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WPEBackend-android internals and API has been rewritten for fence support.
This patch adapts new API and posts fence FD to SurfaceControl for synchronization