Skip to content

Conversation

MarielaTihova
Copy link
Contributor

Related to IgniteUI/grid-demos#126

Implementation of Chart Demos Pages.

Unfortunately it is a big PR because of the many new components and views. I have pushed things into smaller commits for easier tracking.

  • To run charts, go to home/charts/column-chart (or any of the chart names at the last position of the URL)
  • You can also see each chart page separately outside of home/ on charts/column-chart (or any of the chart names at the last position of the URL)
  • There is no button or anything leading to these pages. You have to manually type the URL

What is left (After further clarifications from Marketing and UX teams)

  1. Download links for each chart
  2. Possible changes on fonts and colors for the headers
  3. Possible changes on the design about chart tabs (Up to this moment designs for charts other than Line/Area chart are missing. As agreed upon with the UX team they have been implemented as we (the dev team) see suitable).

@DiLazarova
Copy link

The polar chart in WC needs to have the same transparency for both colors like in Angular and React and also the chart legend is missing here.

Screenshot 2025-08-08 at 14 35 37

@DiLazarova
Copy link

The bar chart is missing a legend, which should be aligned to the left after the heading "Highest-grossing film series."
Screenshot 2025-08-08 at 14 57 32

this one:
Screenshot 2025-08-08 at 14 55 03

@DiLazarova
Copy link

This row-gap should be 16 px, but it is currently set to 8 px

Screenshot 2025-08-08 at 15 01 56

@DiLazarova
Copy link

The line chart legend is missing. Should be aligned to the left after the heading: Renewable Electricity Generated

Screenshot 2025-08-08 at 15 16 35

@DiLazarova
Copy link

The pie chart uses the sans serif font "Titillium Web", as in React and Angular is "Nunito Sans", sans serif. Please use one font style for all information in the legend and a similar font weight. And also the legend is missing here.

Screenshot 2025-08-08 at 15 27 46

@DiLazarova
Copy link

In the Step Chart the legend is missing after the heading: Renewable Electricity Generated;

Screenshot 2025-08-08 at 15 32 03

@DiLazarova
Copy link

The text in the legend should be center aligned with the bullets, applies to all charts.
Screenshot 2025-08-15 at 14 20 18
Screenshot 2025-08-15 at 14 28 56

@DiLazarova
Copy link

Let's use Titillium Web Font for all Chart Labels and Series, and use the same Font Size in the Legend - (Headline -24 px, Series - 12px), applies to all charts. Let's change the Title here also.
Screenshot 2025-08-15 at 14 54 28

* trial to licenseded manual string replace

* remove trial string match

* remove comma

* change trial to licensed logic

* use webcomponents

* reorder tasks

* modify script

* use cli

* wc string edit

* wip check package.json

* wip-test package.json

* revert change

* modify ts string replace

* modify tsx scipt

* modify script

* modify script again

* add missing curly brace

* adjust script

* Separate projects/charts

* Traceability improvements

* remove commented out code

* Improve trial to licensed logging
@dkamburov dkamburov requested a review from DiLazarova August 19, 2025 14:11
@dkamburov dkamburov added the ✅ status: verified Applies to PRs that have passed manual verification label Aug 19, 2025
@MarielaTihova
Copy link
Contributor Author

The text in the legend should be center aligned with the bullets, applies to all charts. Screenshot 2025-08-15 at 14 20 18 Screenshot 2025-08-15 at 14 28 56

This is part of the Chart components legends. It's not custom for the grid-demos, so I am leaving it s it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants