Skip to content

refactor(navigation-drawer): remove nav tag since it is added from the component itself #3559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

refactor(navigation-drawer): remove nav tag since it is added from the component itself #3559

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
714ba82
refactor(navigation-drawer): remove nav tag since it is added from th…
desig9stein Nov 4, 2024
c4cbce5
Merge branch 'master' into mpopov/update-navdrawer-samples
desig9stein Jun 19, 2025
40bf797
Merge branch 'master' into mpopov/update-navdrawer-samples
desig9stein Jun 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions projects/app-lob/src/app/index/index.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
<igx-nav-drawer #navdrawer [enableGestures]="drawerState.enableGestures" [isOpen]="drawerState.open" [(pin)]="drawerState.pin"
[position]="drawerState.position" [width]="drawerState.width" (opened)="refresh()" (closed)="refresh()">
<ng-template igxDrawer>
<nav>
<div class="nav-header">
<img class="logo" src="assets/images/rsrcs/igniteui-angular_logo.svg" alt="Ignite UI for Angular Logo">
</div>
Expand Down Expand Up @@ -48,7 +47,6 @@
</span>
</span>
}
</nav>
</ng-template>
</igx-nav-drawer>

Expand Down
2 changes: 0 additions & 2 deletions src/app/index/index.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
<igx-nav-drawer #navdrawer [enableGestures]="drawerState.enableGestures" [isOpen]="drawerState.open" [(pin)]="drawerState.pin"
[position]="drawerState.position" [width]="drawerState.width" (opened)="refresh()" (closed)="refresh()">
<ng-template igxDrawer>
<nav>
<div class="nav-header">
<img class="logo" src="assets/images/rsrcs/igniteui-angular_logo.svg" alt="Ignite UI for Angular Logo">
</div>
Expand Down Expand Up @@ -53,7 +52,6 @@
</span>
</span>
</span> -->
</nav>
</ng-template>
</igx-nav-drawer>

Expand Down
2 changes: 0 additions & 2 deletions src/app/menus/navdrawer/nav-drawer-pin/nav-drawer-pin.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
<div class="content-wrap" igxLayout>
<igx-nav-drawer id="navigation" #drawer [isOpen]="true" [pin]="true" [pinThreshold]="0">
<ng-template igxDrawer>
<nav>
<span igxDrawerItem [isHeader]="true">Components</span>

@for (item of navItems; track item) {
Expand All @@ -10,7 +9,6 @@
<span>{{ item.text }}</span>
</span>
}
</nav>
</ng-template>
</igx-nav-drawer>

Expand Down
2 changes: 0 additions & 2 deletions src/app/menus/navdrawer/nav-drawer-routing/nav-drawer-routing.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
<div class="content-wrap">
<igx-nav-drawer id="navigation" #drawer [isOpen]="true">
<ng-template igxDrawer>
<nav>
<span igxDrawerItem [isHeader]="true">Components</span>

@for (item of componentLinks; track item) {
Expand All @@ -15,7 +14,6 @@
{{item.name}}
</span>
}
</nav>
</ng-template>
</igx-nav-drawer>

Expand Down
2 changes: 0 additions & 2 deletions src/app/menus/navdrawer/nav-drawer-simple/nav-drawer-simple.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
<div class="content-wrap">
<igx-nav-drawer id="navigation" #drawer [isOpen]="true" [pinThreshold]="5000">
<ng-template igxDrawer>
<nav>
<span igxDrawerItem [isHeader]="true">Components</span>

@for (item of navItems; track item) {
Expand All @@ -10,7 +9,6 @@
<span>{{ item.text }}</span>
</span>
}
</nav>
</ng-template>
</igx-nav-drawer>

Expand Down
Loading