Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using pyrealm within the Plants model #707

Draft
wants to merge 38 commits into
base: develop
Choose a base branch
from

Conversation

davidorme
Copy link
Collaborator

@davidorme davidorme commented Jan 30, 2025

Description

This PR is to replace the placeholder internals of the Plants Model with actual pyrealm functionality. That is very hard to do in small steps, so this will be a large PR.

  • Replaces old plants config with new setup for T model parameters
  • Replaces flora structure with pyrealm Flora
  • Replaces cohort structure with pyrealm Cohorts
  • Replaces community structure with pyrealm Community
  • Uses pyrealm demography functionality to go from cohort DBH data to allometry
  • Uses PModel to estimate GPP and transpiration.

Fixes #659
Fixes #655

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist

🔥 Make sure you've run the pre-commit checks: $ pre-commit run -a
🔥 All tests pass: $ poetry run pytest

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works
  • Relevant documentation reviewed and updated

@davidorme davidorme linked an issue Jan 30, 2025 that may be closed by this pull request
@davidorme davidorme marked this pull request as draft January 31, 2025 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update plants model to use pyrealm flora definition Switch plant model community handling to use pyrealm
1 participant