Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up of test_sycl_queue_submit_local_accessor_arg.cpp #1990

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

oleksandr-pavlyk
Copy link
Collaborator

Clean-up of "libsyclinterface/tests/test_sycl_queue_submit_local_accessor_arg.cpp" file:

  1. Save filename of the test SPV into a variable and reuse it
  2. Add static_assert that SIZE is divisible by 10
  3. Replaced hard-coded expected value with one that depends on value of SIZE
  4. Fixed typos in the source code to generate SPV files
    a. Use #include <sycl/sycl.hpp> instead of #include <CL/sycl.hpp> to reduce deprecation warning
    b. Add missing instantiation for test for uint16_t

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

1. Save test SPV filename into a variable
2. Add static assert that SIZE must be divisible by 10
3. Replaced hard-coded expected value with one that depends on SIZE
4. Fixed typos in the source code to generate SPV files
    a. Use #include <sycl/sycl.hpp>
    b. Add missing instantiation for uint16_t
Copy link

Copy link

Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_516 ran successfully.
Passed: 895
Failed: 1
Skipped: 118

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant