Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for composite devices #1993

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Support for composite devices #1993

wants to merge 10 commits into from

Conversation

ndgrigorian
Copy link
Collaborator

@ndgrigorian ndgrigorian commented Feb 14, 2025 •
edited
Loading

This PR proposes supporting the oneAPI composite devices extension in dpctl, which exposes multi-tile GPU devices as root devices for each tile, but also provides access to the composite devices from level zero prior to ZE_FLAT_DEVICE_HIERARCHY=FLAT becoming the default. i.e., with ZE_FLAT_DEVICE_HIERARCHY=COMPOSITE, the composite devices are root devices, but with ZE_FLAT_DEVICE_HIERARCHY=COMBINED, a user gains access to these composite devices through dedicated APIs.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

@github-actions GitHub Actions
Copy link

View rendered docs @ https://intelpython.github.io/dpctl/pulls/1993/index.html

@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl= ran successfully.
Passed: 893
Failed: 3
Skipped: 118

@coveralls
Copy link
Collaborator

coveralls commented Feb 14, 2025 •
edited
Loading

Coverage Status

coverage: 87.72% (-0.4%) from 88.083%
when pulling 8327887 on support-composite-devices
into 7aa6fb7 on master.

@ndgrigorian ndgrigorian force-pushed the support-composite-devices branch 2 times, most recently from 2d5942d to 76f2fc2 Compare February 21, 2025 20:55
@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_544 ran successfully.
Passed: 894
Failed: 2
Skipped: 118

@ndgrigorian ndgrigorian force-pushed the support-composite-devices branch from 76f2fc2 to 00cb089 Compare March 1, 2025 09:10
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 1, 2025

Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_25 ran successfully.
Passed: 897
Failed: 0
Skipped: 125

@ndgrigorian
Add dpctl.get_composite_devices
63b154d 
This leverages oneAPI extension for composite devices to add the free function `ext_oneapi_get_composite_devices` to the main dpctl namespace
@ndgrigorian
Adds get_composite_devices method to dpctl.SyclPlatform
dd363ff 
This method is only applicable for level_zero backend, returning an empty list for all other backend types
@ndgrigorian
Add composite device related attributes to dpctl.SyclDevice
cc5ef08
@ndgrigorian ndgrigorian force-pushed the support-composite-devices branch from 00cb089 to cc5ef08 Compare March 5, 2025 17:03
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2025

Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_27 ran successfully.
Passed: 896
Failed: 1
Skipped: 126

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2025

Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_31 ran successfully.
Passed: 895
Failed: 2
Skipped: 126

@ndgrigorian ndgrigorian force-pushed the support-composite-devices branch from 7ea744b to b8c765f Compare March 6, 2025 02:31
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2025

Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_31 ran successfully.
Passed: 895
Failed: 2
Skipped: 126

@ndgrigorian ndgrigorian force-pushed the support-composite-devices branch from b1be1ee to 4ab4cb0 Compare March 6, 2025 05:41
@ndgrigorian ndgrigorian force-pushed the support-composite-devices branch from 4ab4cb0 to 8327887 Compare March 6, 2025 05:44
@ndgrigorian ndgrigorian marked this pull request as ready for review March 6, 2025 05:45
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2025

Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_34 ran successfully.
Passed: 895
Failed: 2
Skipped: 126

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2025

Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_34 ran successfully.
Passed: 895
Failed: 2
Skipped: 126

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2025

Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_34 ran successfully.
Passed: 896
Failed: 1
Skipped: 126

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy Awaiting requested review from antonwolfy antonwolfy is a code owner

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@vtavana vtavana Awaiting requested review from vtavana vtavana is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ndgrigorian @coveralls