Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update skipped tests #1801

Merged
merged 7 commits into from
Apr 28, 2024
Merged

Update skipped tests #1801

merged 7 commits into from
Apr 28, 2024

Conversation

vlad-perevezentsev
Copy link
Collaborator

This PR suggests reviewing skipped tests in skipped_tests_gpu_no_fp64,tbl, skipped_tests_gpu,tbl and skipped_tests.tbl files and deleting tests in them that work with new packages.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

Copy link
Contributor

github-actions bot commented Apr 25, 2024

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@vlad-perevezentsev vlad-perevezentsev marked this pull request as ready for review April 26, 2024 10:36
@vlad-perevezentsev vlad-perevezentsev self-assigned this Apr 26, 2024
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The below tests is failing on GPU device on PVC:

tests/test_umath.py::test_umaths[('floor_divide', 'ff')]

Could you please mute it in scope of that PR? The issue is already addressed to dpctl in gh-1652.

Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vlad-perevezentsev for revising muted dpnp tests.

@antonwolfy antonwolfy merged commit 8a378b4 into master Apr 28, 2024
56 checks passed
@antonwolfy antonwolfy deleted the update_skipped_tests branch April 28, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants