Skip to content

update mkl_umath to align it with numpy-2.* #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Apr 26, 2025

In this PR, mkl_umath is aligned with numpy-2.*. The changes include:

  1. the definition of numpy.sign for complex number is updated in numpy-2.*, mkl_umath is modified accordingly.
  2. documentation for ufunc is updated. Now we have two documentation files which are borrowed from NumPy one is for numpy-1.26.4 and the other one for the most recent version of NumPy, i.e. numpy-2.2.5.
  3. In both numpy-1.26.4, and numpy-2.2.5, true_divide is an alias of divide. The same change is made in mkl_umath. Previously, divide was an alias of true_divide.
  4. generate_umath.py is updated to align with numpy-2.2.5.
  5. new workflows are added to build and test the package with both numpy<2 and numpy>=2.

@vtavana vtavana self-assigned this Apr 26, 2025
@ndgrigorian
Copy link
Collaborator

@vtavana
should we add conditional definition based on if NumPy > 2? Since we still are supporting 1.26.4

@vtavana
Copy link
Collaborator Author

vtavana commented Apr 28, 2025

@vtavana should we add conditional definition based on if NumPy > 2? Since we still are supporting 1.26.4

@ndgrigorian Yes, I am planning to do it. The PR is a draft and not finalized yet

@vtavana vtavana force-pushed the update-sign branch 3 times, most recently from 960f08c to 4c1863f Compare April 29, 2025 03:33
@vtavana vtavana changed the title update sign function for complex numbers update mkl_umath to align it with numpy-2.* Apr 29, 2025
@vtavana vtavana marked this pull request as ready for review April 29, 2025 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants