-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify and fix the descriptions of parsedSections
for JS API
#131
Open
hrlyg
wants to merge
8
commits into
InteractiveAdvertisingBureau:main
Choose a base branch
from
hrlyg:parsedsections
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janwinkler
approved these changes
Nov 14, 2024
patmmccann
reviewed
Nov 14, 2024
patmmccann
suggested changes
Nov 14, 2024
patmmccann
approved these changes
Dec 19, 2024
Thanks for incorporating my suggestions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes:
In the CMP API specification doc,
PingReturn.parsedSections
should be consistent with the GPP string.PingReturn.parsedSections
and added an example.Datetime
field isDate
, so the examples should useDate
notstring
. Please note that in JS,new Date(...)
produces aDate
object, and a mereDate(...)
produces astring
.GPPExtension: IAB Canada TCF.md
hasSubsectionType
, notsubsectionType
, so the example should use the former spelling.PingReturn
description more readable, by adding line breaks to comments that are too long.In each individual spec,
PingReturn.parsedSections
.PingReturn.parsedSections
should be the one source of truth.