-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch off lower prio appliances to switch on higher prio appliances #72
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks this looks good, just noted some typos, may be worth noting that there will be a spike in power over the produced power before the lower priority ones are turned off
Co-authored-by: Carlos Sanchez <[email protected]>
Co-authored-by: Carlos Sanchez <[email protected]>
:-) Yes, but in general this is the normal behavior of this script. An appliance is switched off, if the produced power isn't sufficient. And many appliances do not need the full power directly after being switched on. And the lower prioritized appliances will be switched off only a few ms later. Therefore I think it is better this way, than to wait one minute before switching on. Thank you very much for your suggestions, all of them are now in this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just 2 typos
Co-authored-by: Carlos Sanchez <[email protected]>
Co-authored-by: Carlos Sanchez <[email protected]>
Thank you :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've run with this patch for some days and it looks to be working correctly
Co-authored-by: Carlos Sanchez <[email protected]>
One thing that I noticed that is not going to work well. If you have devices with no power measurement that are not consuming at the time then the algorithm will overestimate how much power can be freed, then turn on the higher priority appliance just to turn it off in the next minute, and so on. |
No description provided.