-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
secp256k1
precompiles: add
, double
and decompress
+ refactor
#4
base: master
Are you sure you want to change the base?
Conversation
d59fdd3
to
efb901d
Compare
efb901d
to
0e168a9
Compare
2912a73
to
b189845
Compare
b189845
to
3df34fe
Compare
secp256k1_add
secp256k1
precompiles: add
, double
and decompress
+ refactor
For the purpose of compatibility and avoiding surprises I think we should do that too, with a comment to remember that it is the only reason.
Ceno memory system works with 4-bytes words on 4-bytes alignment; there are no benefits with 8. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work with batteries included!
- Witgen & Runtime integration
- Refactoring & Clarity
- Specs & Refs & Comments
- Tests & Examples & Compatibility
➜ I think there are some memory ops missing, see comments.
Note: this PR is done against Inversed's fork master, do not merge.
secp256k1_add
,secp256k1_double
andsecp256k1_decompress
precompiles with the same interface assp1
, but backed by thesecp
crate.utils.rs
with some utilities for manipulating memory segments of the VM.syscalls.rs
example file).Questions:
keccak
which inputsu64
s, it could be aligned to8
bytes).