Find custom set symbols by set code #14
Open
+25
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Search for set symbols in both the custom and the official directories, preferring custom over official and svgs over pngs. This way, people can just drop their own set symbols into img/setSymbols/custom/ and use the set code like they'd do for official cards. Unfortunately this will log a 404 error message to console whenever we fail to find an image. I'm not aware of any way to avoid this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, cardconjurer searches for set symbol images in both the custom and the official directories, preferring custom over official symbols and svgs over pngs. This way, people don't have to manually add their own set symbols with the "Via URL" field, they can just drop them into img/setSymbols/custom/ and use the set code and rarity fields like they'd do for official cards.
This also makes the weird hardcoding of specific set codes that have pngs instead of svgs or that are located in img/setSymbols/custom instead of img/setSymbols/official unnecessary.
Unfortunately this will log a 404 error message to console whenever we fail to find an image. I'm not aware of any reasonable way to avoid this--apparently you could register a service worker and have that handle the fetch but that seems like overkill to me.