-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.NET 7.0 #1358
.NET 7.0 #1358
Conversation
2464678
to
480a7af
Compare
b7dbe1a
to
f925fc4
Compare
@BCSharp Are you able to reproduce the failure on macOS with .NET 7? I think it's occurring in |
Yes, I was able to reproduce the failure. The test crashes on All in all, I don't have a feeling that it is caused by a problem in .NET 7.0, more likely, the implementation in .NET 7.0 changed somehow that it uses more method calls on the stack than before, which, when accumulated, push the process over the edge. To make the test pass temporarily, you may set |
Thanks for the tip. I was able to reproduce the failure on Windows by bumping the range to 25000 and on .NET 6 (with 50000). I managed to get the same stack overflow running directly in C# so that rules out an IronPython issue: var sb = new StringBuilder();
sb.Append(0);
for(int i=1; i<25000; i++)
{
sb.Append('|');
sb.Append(i);
}
Regex.Match("1000", sb.ToString(), RegexOptions.Compiled); But as you say we must be right near the limit on macOS and IronPython's stack is pushing it over the edge. I will try |
Any timeline around when we can expect net7.0 support? |
@DamianReeves This PR only enables the test suite. Is there a problem running the existing (.NET 6) DLLs on .NET 7? |
No description provided.