Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define UnsupportedOSPlatformAttribute #1829

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

BCSharp
Copy link
Member

@BCSharp BCSharp commented Dec 4, 2024

I had added UnsupportedOSPlatformAttribute in the past already several times, only to remove it again when the final version submitted as a pull request didn't use it. Now again, I have code that uses it, although it is not the final version so in the end it may again not be using it. Nevertheless, I'd like to add this attribute and get it over with for the future. It doesn't harm if it's unused, but it is good to have it available, if needed.

Copy link
Contributor

@slozier slozier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@slozier slozier merged commit 8504f29 into IronLanguages:main Dec 5, 2024
6 of 8 checks passed
@BCSharp BCSharp deleted the ptfm_unsup branch December 5, 2024 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants