Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add VIIRS J1 albedo geovals and obs file for ufo test #473

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Add VIIRS J1 albedo geovals and obs file for ufo test #473

wants to merge 2 commits into from
+6 −0

Conversation

weiwilliam
Copy link
Contributor

Description

This PR adds geoval and observation files for the new ufo tests ufo_test_tier1_test_ufo_opr_crtm_vis_albedo_aerosol and ufo_test_tier1_test_ufo_linopr_crtm_vis_albedo_aerosol.

Issue(s) addressed

Resolves #<issue_number>

Dependencies

List the other PRs that this PR is dependent on:

  • [ ]

Impact

N/A

Checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have run the unit tests before creating the PR

@weiwilliam weiwilliam self-assigned this Feb 19, 2025
@weiwilliam weiwilliam added the COMPO Atmospheric COMPOsition label Mar 4, 2025
fcvdb
fcvdb reviewed Mar 11, 2025
View reviewed changes
Copy link
Collaborator

@fcvdb fcvdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File testinput_tier_1/viirs_j1_albedo-small.geovals.2021082315.nc4 is 2.&Mb. Could you reduce its size to less than 1Mb?

@weiwilliam
Copy link
Contributor Author

File testinput_tier_1/viirs_j1_albedo-small.geovals.2021082315.nc4 is 2.&Mb. Could you reduce its size to less than 1Mb?

@fcvdb No problem, it is 10 times smaller.

fcvdb
fcvdb approved these changes Mar 25, 2025
View reviewed changes
Copy link
Collaborator

@fcvdb fcvdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Shih-Wei!

@fcvdb fcvdb added the coordinate merge Ready for merge but needs to be coordinated with other repos label Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fcvdb fcvdb fcvdb approved these changes

@jeromebarre jeromebarre Awaiting requested review from jeromebarre

@huishao-r huishao-r Awaiting requested review from huishao-r

@BenjaminRuston BenjaminRuston Awaiting requested review from BenjaminRuston

At least 2 approving reviews are required to merge this pull request.

Assignees

@weiwilliam weiwilliam

Labels
COMPO Atmospheric COMPOsition coordinate merge Ready for merge but needs to be coordinated with other repos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weiwilliam @fcvdb